-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LUM-789] Patch broken deposit entities #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebascou
approved these changes
Aug 3, 2023
Segfaultd
added a commit
that referenced
this pull request
Aug 3, 2023
* Handle pool paused state * WIP import updates and project clean up * Allow native zone toAddress * Fix all errors - not compiling yet * Use new ICA server implem - to be thoroughly tested * Fix missing crisis key in store * Fix go mod according to upgrade guide * Prepare buf config * Update to new makefile base proto gen * Update workflow * Fix workflow * Fix lint workflow * Handle re-delegate assets from a disabled validator * Adjust return type * Exclude rand error from gosec * Add new makefile cmd to check for formatting issues * Add new workflows and associated cmds and scripts * Fix workflow * Add missing goimports and update readme * Use official lint workflow * Remove unused code * Add new auto formatted proto generated files * Apply new formatting rules * clean up linting * Fix new IBC msg server use of timeout timestamp * Rollback ci lint version * Fix dfract linting * Fix beam lint issues * Remove use of legacy fundraiser path in favour of new config * Bump lint ci * Attempt to fix CI * Another attemp to fix this lint ci * Bump golangci-lint version * Add improvement for test proposal handler and redelegate retry * Add edit deposit feature * Fix format check * Fix linting errors * Update metadata for EditDeposit and ValidateBasic static check * Fix import ordering * Review proto folders structure * Remove unused simulation code * Add proper query srv implem * Revamp RedelegateRetry and migrate to UpdatePool handler * Migrate Redelegate to UpdatePool and update tests * Cleanup of unused code and proto * Add pool security check for UpdateRedelegateStatus * Use utils function instead of hardcoded disabledValidators in pool_test * Verify redelegate with deposit success and avoid double funding for ica pool address * Fix typo in comment * Fix cmd new commands * Introduce RebalanceValidatorsBondings and Remove Redelegate State * Improve RebalanceValidatorsBondings and Redelegate handling * Use inactiveVal for OnRedelegateToRemoteZoneCompleted * Merge the 2 unit tests together * Add airdrop tx proto and chainID in root for ignite compatibility on sdk.047 * Add RebalanceValidatorsBondings condition, params improvement for RedelegateToActiveValidators and helper functions * Add valSrcAddr for ValidateUnbondAmount * Set default modules key tables * Added missing IBC migrations and fixed types naming * Prune expired client states * Register the tendermint light client * Fix codecs registration * Revert "Fix codecs registration" This reverts commit 148b730. * Move back proto to their original path for backward compatibility * Use store key for consistence * Unused ClaimCapability anymore * Remove capabilities for ownership transfer * Install more dependencies * Redundant implementation * IBC Stack revamp * Add comment * Add new ProposalUpdateParams and WithdrawAndMint tx * Revert to all codec path to avoid changing current deposit path * Add missing end of comment * Fix lint and import ordering * Fixed ignite gov module config * Remove unused errors * Fix typo and add one more test for proposal handler * Fix usage between port owner name and port ID * Fixed ICA callbacks handlers registration * Formatting * Add RegisterMsgServer for RegisterServices in x/millions/module.go * Add RegisterMsgServer to dfract module * Add RegisterMsgServer for RegisterServices in x/airdrop/module.go * Add new NewMsgServerImpl for beam module * Add format for import ordering * Fix draw prizes fees implementation * Apply feedback changes * Add additional tests for invalid depositDenoms * Migrate consensus params and properly register keeper * Fix consensus module registration * Fix implementation following 0.47 sdk upgrade * Add more comment and unify ValidateBasics * Fix comment duplicate wording and test description * [LUM-752] Migrate port IDs (#42) * Added store migrator for port IDs * Fix imports * Fix comment * Migrate DFract params to the new system * formatting * Add config.yml default params for dfract for ignite compatibility * Improve error message for min_deposit_amount check * Add epoch implementation for withdrawals * Rename variables * Remove legacy callback * Remove DS_Store * Remove useless key * fix linter * Fix lint and format check * Fix comments and variables * Update events * update store variable name * same for hasEpochPoolUnbonding * Decrease the limit per withdrawal * Remove useless comments * Add missing genesis * Add migration for failed ICAUndelegations * Added missing upgrade handler * Fix proto implementation * Update store_test.go * Update keepers.go * Bump version * Remove Epochunbonding from genesis and related endpoints * Bump SDK version * Code cleaning * Reduce hardcap limit * use MaxAcceptableWithdrawalIDsCount instead of hardcoded int * Revert the unappropriate split delegation in case of error callback * Fix withdrawal error split computation * Remove glitch in .gitignore * remove useless space * [LUM-789] Patch broken deposit entities (#47) * Patch broken deposit entities * format store migration --------- Co-authored-by: Fabrice Bascoulergue <lebascou@users.noreply.github.com> Co-authored-by: Fabrice Bascoulergue <3663159+lebascou@users.noreply.github.com> Co-authored-by: Segfault <5221072+Segfaultd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Following the issue for which we are releasing #45 we have to patch two deposit entities that are broken.
They should've been flagged with error state by the chain, but since the ICA channel closed, it never received the callback.
This lil change ensure the deposit is flagged on error. We will then ask the entity owner to retry the deposit using the dedicated command.